Paths

Table of Contentst

Differential D19932

Fix the last remaining (?) continue inside switch
ClosedPublic
Actions

Authored by epriestley on Dec 22 2018, 2:12 PM.

Tags

None

Referenced Files

	F14801424: D19932.id47570.diff
	Sat, Jan 25, 10:29 AM

	F14798127: D19932.diff
	Sat, Jan 25, 5:46 AM

	F14795537: D19932.id47581.diff
	Sat, Jan 25, 2:58 AM

	F14795534: D19932.id47570.diff
	Sat, Jan 25, 2:58 AM

	F14795533: D19932.id.diff
	Sat, Jan 25, 2:58 AM

	F14795532: D19932.diff
	Sat, Jan 25, 2:58 AM

	Unknown Object (File)
	Tue, Jan 21, 9:26 AM

	Unknown Object (File)
	Fri, Jan 10, 11:48 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPe98ee73602ac: Fix the last remaining (?) continue inside switch

Summary

See https://discourse.phabricator-community.org/t/error-on-project-creation-or-edition-with-php7-3/2236/. This is the only remaining case that the linter rule in D19931 detected in libphutil, arcanist, or Phabricator.

Test Plan

Ran arc lint --everything ... in all three repositories, only hit this one.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 22 2018, 2:12 PM

Harbormaster completed remote builds in B21423: Diff 47570.Dec 22 2018, 2:13 PM

epriestley requested review of this revision.Dec 22 2018, 2:14 PM

amckinley accepted this revision.Dec 24 2018, 9:20 PM

This revision is now accepted and ready to land.Dec 24 2018, 9:20 PM

Closed by commit rPe98ee73602ac: Fix the last remaining (?) continue inside switch (authored by epriestley). · Explain WhyDec 28 2018, 8:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

2 lines

Diff 47581

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Fix the last remaining (?) continue inside switchClosedPublicActions