Continue clean up of super-old code. I am pretty proud of "defrocked", but would also consider "dethroned", "ousted", "unseated", "unmade", or "disenfranchised". I feel like there's a word for being kicked out of Hogwarts and having your wizarding powers revoked, but it is not leaping to mind.
Details
Details
- Reviewers
epriestley - Commits
- rPb6999c7ef41d: Move admin promotions to modular transactions
Promoted/demoted users to/from admin, attempted to demote myself and observed preserved witty text, checked user timelines, checked feed, checked DB for sanity, including user_logs. I didn't test exposing this via Conduit to attempt promoting a user without having admin access.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- make-admin (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21345 Build 29051: Run Core Tests Build 29050: arc lint + arc unit
Event Timeline
Comment Actions
I feel like there's a word for being kicked out of Hogwarts and having your wizarding powers revoked, but it is not leaping to mind.
Maybe it's "muggleize".
Or "moogled" (from Secret of Mana?)
Change looks good.