Page MenuHomePhabricator

Move admin promotions to modular transactions
ClosedPublic

Authored by amckinley on Dec 14 2018, 11:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 31 2024, 8:32 PM
Unknown Object (File)
Jan 31 2024, 8:19 PM
Unknown Object (File)
Jan 12 2024, 2:23 PM
Unknown Object (File)
Dec 20 2023, 2:39 PM
Unknown Object (File)
Dec 17 2023, 8:55 PM
Unknown Object (File)
Nov 30 2023, 7:30 PM
Unknown Object (File)
Nov 30 2023, 5:46 AM
Unknown Object (File)
Nov 19 2023, 12:29 AM
Subscribers

Details

Summary

Continue clean up of super-old code. I am pretty proud of "defrocked", but would also consider "dethroned", "ousted", "unseated", "unmade", or "disenfranchised". I feel like there's a word for being kicked out of Hogwarts and having your wizarding powers revoked, but it is not leaping to mind.

Test Plan

Promoted/demoted users to/from admin, attempted to demote myself and observed preserved witty text, checked user timelines, checked feed, checked DB for sanity, including user_logs. I didn't test exposing this via Conduit to attempt promoting a user without having admin access.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I feel like there's a word for being kicked out of Hogwarts and having your wizarding powers revoked, but it is not leaping to mind.

Maybe it's "muggleize".

Or "moogled" (from Secret of Mana?)

Change looks good.

This revision is now accepted and ready to land.Dec 14 2018, 11:37 PM
This revision was automatically updated to reflect the committed changes.