Page MenuHomePhabricator
Differential D19840

When the last rejecting reviewer resigns from a revision, return it to "Needs Review"
ClosedPublic
Actions

Authored by epriestley on Nov 26 2018, 2:06 PM.
Tags
None
Referenced Files
F15515623: D19840.id47372.diff
Fri, Apr 18, 12:01 PM
F15489901: D19840.diff
Fri, Apr 11, 1:15 PM
F15473558: D19840.diff
Sat, Apr 5, 11:39 PM
F15462270: D19840.diff
Tue, Apr 1, 1:35 PM
F15449246: D19840.id47369.diff
Fri, Mar 28, 9:05 AM
F15433470: D19840.diff
Mon, Mar 24, 11:23 PM
F15419699: D19840.id47372.diff
Mar 21 2025, 8:12 AM
F15379897: D19840.diff
Mar 14 2025, 12:03 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12920: Retracting requested changes can leave revision in "Needs Revision" state
T13216: 2018 Week 45-47 Bonus Content
Commits
rP97e7ef0f015c: When the last rejecting reviewer resigns from a revision, return it to "Needs…
Summary

Ref T13216. Fixes T12920. See PHI911. If you reject a revision and then resign from it, it stays in "Needs Revision".

There's some arguable motivation for this, but it's inconsistent with how "Accept" works (if the last accepting reviewer resigns, we kick you out of "Accepted"). Make it consistent.

Test Plan
  • As the only reviewer: requested changes to a revision, then resigned.
  • Before: revision stays in "Needs Revision".
  • After: revision moves back to "Needs Review".

Diff Detail

Repository
rP Phabricator
Branch
resign-after-reject1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21218
Build 28861: Run Core Tests
Build 28860: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
5 lines

Diff 47369

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
Phabricator · Built by Phacility