Page MenuHomePhabricator

When the last rejecting reviewer resigns from a revision, return it to "Needs Review"
ClosedPublic

Authored by epriestley on Nov 26 2018, 2:06 PM.
Tags
None
Referenced Files
F12813331: D19840.diff
Thu, Mar 28, 1:05 AM
Unknown Object (File)
Tue, Mar 26, 7:13 PM
Unknown Object (File)
Tue, Mar 26, 7:13 PM
Unknown Object (File)
Thu, Mar 21, 8:14 AM
Unknown Object (File)
Tue, Mar 19, 10:49 PM
Unknown Object (File)
Wed, Mar 13, 5:27 AM
Unknown Object (File)
Feb 22 2024, 1:16 AM
Unknown Object (File)
Feb 3 2024, 8:02 PM
Subscribers
None

Details

Summary

Ref T13216. Fixes T12920. See PHI911. If you reject a revision and then resign from it, it stays in "Needs Revision".

There's some arguable motivation for this, but it's inconsistent with how "Accept" works (if the last accepting reviewer resigns, we kick you out of "Accepted"). Make it consistent.

Test Plan
  • As the only reviewer: requested changes to a revision, then resigned.
  • Before: revision stays in "Needs Revision".
  • After: revision moves back to "Needs Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable