Page MenuHomePhabricator

Tailor the "no reviewers on this revision" warnings to handle the case where all reviewers have resigned
ClosedPublic

Authored by epriestley on Nov 24 2018, 2:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 12:48 AM
Unknown Object (File)
Sat, Dec 14, 4:40 PM
Unknown Object (File)
Sun, Dec 8, 11:00 AM
Unknown Object (File)
Sun, Dec 1, 3:57 PM
Unknown Object (File)
Sun, Dec 1, 3:57 PM
Unknown Object (File)
Wed, Nov 27, 4:29 PM
Unknown Object (File)
Nov 24 2024, 9:09 PM
Unknown Object (File)
Nov 24 2024, 2:14 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI985. We currently use a banner to warn you when a revision has no reviewers or only disabled users, but since the changes to track "Resign" more explicilty we'll no longer warn you if everyone has resigned.

(Previously, they'd no longer be reviewers, so you'd end up with the "no reviewers are assigned" warning if everyone resigned.)

This can still interact slightly oddly with some states (e.g., only a package or project reviewer) but I'd like to wait for T731 to tighten those cases up, and they're more advanced/unusual.

Test Plan

Screen Shot 2018-11-24 at 6.41.12 AM.png (942×1 px, 163 KB)

Screen Shot 2018-11-24 at 6.40.51 AM.png (942×1 px, 161 KB)

Screen Shot 2018-11-24 at 6.40.55 AM.png (942×1 px, 160 KB)

Diff Detail

Repository
rP Phabricator
Branch
noreviewers1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21208
Build 28843: Run Core Tests
Build 28842: arc lint + arc unit