Paths

Table of Contentst

Differential D19802

Improve performance of two recent commit migrations
ClosedPublic
Actions

Authored by epriestley on Nov 14 2018, 5:45 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13216: 2018 Week 45-47 Bonus Content

Commits

rP96f9b0917e21: Improve performance of two recent commit migrations

Summary

Ref T13216. See PHI959. These two recent migrations can be expressed more efficiently:

When updating commit audit statuses, the field isn't JSON encoded or anything so we can just issue several bulk UPDATEs.
When inserting mail keys, we can batch them in groups of 100.

Test Plan

Used bin/storage upgrade -f --apply phabricator:... to reapply patches. Saw equivalent behavior and faster runtimes.

Diff Detail

Repository

rP Phabricator

Branch

mig1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21143
Build 28743: Run Core Tests
Build 28742: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 14 2018, 5:45 PM

Owners added a subscriber: Restricted Owners Package.Nov 14 2018, 5:45 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 14 2018, 5:46 PM

Harbormaster failed remote builds in B21143: Diff 47294!

Stacked on qsprintf() stuff.

amckinley accepted this revision.Nov 15 2018, 3:28 AM

This revision is now accepted and ready to land.Nov 15 2018, 3:28 AM

Closed by commit rP96f9b0917e21: Improve performance of two recent commit migrations (authored by epriestley). · Explain WhyNov 15 2018, 11:52 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180910.audit.03.status.php

16 lines

20180914.audit.01.mailkey.php

32 lines

Diff 47294

View Options

resources/sql/autopatches/20180910.audit.03.status.php