Page MenuHomePhabricator

Correct a mangled translation string in "bin/phd log --id X"
ClosedPublic

Authored by epriestley on Oct 24 2018, 4:41 PM.
Tags
None
Referenced Files
F13159336: D19755.id47206.diff
Mon, May 6, 1:27 AM
Unknown Object (File)
Fri, May 3, 4:36 AM
Unknown Object (File)
Thu, Apr 25, 12:38 AM
Unknown Object (File)
Fri, Apr 19, 9:01 AM
Unknown Object (File)
Fri, Apr 19, 6:51 AM
Unknown Object (File)
Thu, Apr 18, 11:32 PM
Unknown Object (File)
Sat, Apr 13, 5:45 PM
Unknown Object (File)
Mar 30 2024, 6:09 AM
Subscribers
None

Details

Summary

Ref T13210. See PHI930. This translation is wrong: the parameter is a comma-separated list as a string, but the USEnglish translation provides alternatives. We can't select among alternatives based on a random string (it isn't a plurality value to let us select "chair" vs "chairs", and isn't a gender value to let us select "his profile" vs "her profile") so we get an error.

But the string itself is also misleading, since "bin/phd log --id A --id B --id C" will say "none of these are valid" if any of them are invalid.

Instead, just tell the user explicitly about the first problem.

Test Plan
  • Ran bin/phd log --id with good (got logs) and bad IDs (got sensible error).
  • Ran bin/phd log with any logs (got logs) and (simluated) without any logs (got error).

Diff Detail

Repository
rP Phabricator
Branch
phdlog1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21033
Build 28576: Run Core Tests
Build 28575: arc lint + arc unit