" by default
ClosedPublic
Actions

Authored by epriestley on Oct 11 2018, 7:38 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13210: Plans: 2018 Week 41-44 Bonus Content

Commits

rP8bffc9ea0efe: In "bin/bulk export", require "--output <path>" by default

Summary

Depends on D19743. Ref T13210. Since this command can easily dump a bunch of binary data (or just a huge long blob of nonsense) to stdout, default to requiring "--output <file>".

Using --output - will print to stdout.

Test Plan

Ran with: no --output, --output file, --output -, --output - --overwrite. Got sensible results or errors in all cases.

Diff Detail

Repository

rP Phabricator

Branch

discover4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21011
Build 28543: Run Core Tests
Build 28542: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 11 2018, 7:38 PM

Harbormaster completed remote builds in B21011: Diff 47168.Oct 11 2018, 7:40 PM

epriestley requested review of this revision.Oct 11 2018, 7:40 PM

amckinley accepted this revision.Oct 11 2018, 8:29 PM

This revision is now accepted and ready to land.Oct 11 2018, 8:29 PM

Closed by commit rP8bffc9ea0efe: In "bin/bulk export", require "--output <path>" by default (authored by epriestley). · Explain WhyOct 11 2018, 8:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

bulk/

management/

PhabricatorBulkManagementExportWorkflow.php

27 lines

Diff 47168

View Options

src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php

In "bin/bulk export", require "--output <path>" by defaultClosedPublicActions