Page MenuHomePhabricator

Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to scroll
ClosedPublic

Authored by epriestley on Oct 1 2018, 6:08 PM.
Tags
None
Referenced Files
F13162599: D19723.diff
Mon, May 6, 2:32 PM
Unknown Object (File)
Fri, May 3, 5:28 AM
Unknown Object (File)
Tue, Apr 30, 6:24 AM
Unknown Object (File)
Thu, Apr 25, 12:54 AM
Unknown Object (File)
Fri, Apr 19, 8:02 PM
Unknown Object (File)
Thu, Apr 11, 8:39 AM
Unknown Object (File)
Apr 2 2024, 8:47 AM
Unknown Object (File)
Apr 2 2024, 8:47 AM
Subscribers
None

Details

Summary

Ref T13202. See https://discourse.phabricator-community.org/t/phriction-page-controls-lost-after-creating-very-wide-table/1961.

If you put a very wide table in the markup for a new-layout Phriction page, it can push the actions element off screen to the right.

Tables already get a scrollbar if encouraged strongly enough; add a max-width to encourage them.

Test Plan
  • Viewed pages with a large wrappable and non-wrappable content on mobile, tablet, and desktop.

Screen Shot 2018-10-01 at 11.06.29 AM.png (1×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Branch
wiki1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20929
Build 28449: Run Core Tests
Build 28448: arc lint + arc unit