Page MenuHomePhabricator

Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to scroll
ClosedPublic

Authored by epriestley on Oct 1 2018, 6:08 PM.
Tags
None
Referenced Files
F14081088: D19723.diff
Fri, Nov 22, 6:23 PM
F14079493: D19723.id47119.diff
Fri, Nov 22, 8:26 AM
Unknown Object (File)
Tue, Nov 19, 9:10 AM
Unknown Object (File)
Oct 16 2024, 2:52 AM
Unknown Object (File)
Oct 13 2024, 6:09 PM
Unknown Object (File)
Sep 11 2024, 8:58 PM
Unknown Object (File)
Sep 9 2024, 11:17 AM
Unknown Object (File)
Sep 6 2024, 4:07 AM
Subscribers
None

Details

Summary

Ref T13202. See https://discourse.phabricator-community.org/t/phriction-page-controls-lost-after-creating-very-wide-table/1961.

If you put a very wide table in the markup for a new-layout Phriction page, it can push the actions element off screen to the right.

Tables already get a scrollbar if encouraged strongly enough; add a max-width to encourage them.

Test Plan
  • Viewed pages with a large wrappable and non-wrappable content on mobile, tablet, and desktop.

Screen Shot 2018-10-01 at 11.06.29 AM.png (1×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable