Page MenuHomePhabricator

[Wilds] Implement a Filesystem::concatenatePaths(...) method
ClosedPublic

Authored by epriestley on Sep 18 2018, 8:01 PM.
Tags
None
Referenced Files
F19091158: D19691.id.diff
Dec 3 2025, 1:50 PM
F19087322: D19691.diff
Dec 3 2025, 12:17 AM
F18867269: D19691.id47067.diff
Nov 3 2025, 10:47 PM
F18860930: D19691.id.diff
Nov 2 2025, 1:47 PM
F18858907: D19691.diff
Nov 1 2025, 11:25 PM
F18769091: D19691.id.diff
Oct 8 2025, 6:28 AM
F18750692: D19691.diff
Oct 4 2025, 8:42 AM
F18739980: D19691.diff
Oct 1 2025, 11:46 PM
Subscribers
None

Details

Summary

Ref T13098. This is mostly for getting sensible results under Windows, hopefully instead of weird mixed paths with both / and \, at least in more cases.

You can pass in several components like array('/path/to/something/', '/thing.c') and they'll be concatenated with exactly one correct separator.

Test Plan

Used this in the new WorkingCopy stuff, which doesn't run yet. 💁

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20857
Build 28369: Run Core Tests

Event Timeline

epriestley created this revision.
This revision is now accepted and ready to land.Sep 19 2018, 11:18 PM
epriestley added inline comments.
src/filesystem/Filesystem.php
1057

("Hilariously", this is missing a third parameter and doesn't work at all, but got fixed later.)

This revision was automatically updated to reflect the committed changes.