Page MenuHomePhabricator

[Wilds] Implement a Filesystem::concatenatePaths(...) method
ClosedPublic

Authored by epriestley on Sep 18 2018, 8:01 PM.
Tags
None
Referenced Files
F14825059: D19691.diff
Tue, Jan 28, 7:20 PM
F14822138: D19691.id47045.diff
Tue, Jan 28, 7:35 AM
Unknown Object (File)
Tue, Jan 21, 11:56 AM
Unknown Object (File)
Tue, Jan 21, 10:01 AM
Unknown Object (File)
Wed, Jan 15, 6:52 PM
Unknown Object (File)
Sun, Jan 12, 9:39 PM
Unknown Object (File)
Sat, Jan 11, 11:01 AM
Unknown Object (File)
Thu, Jan 2, 7:01 PM
Subscribers
None

Details

Summary

Ref T13098. This is mostly for getting sensible results under Windows, hopefully instead of weird mixed paths with both / and \, at least in more cases.

You can pass in several components like array('/path/to/something/', '/thing.c') and they'll be concatenated with exactly one correct separator.

Test Plan

Used this in the new WorkingCopy stuff, which doesn't run yet. 💁

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20857
Build 28369: Run Core Tests

Event Timeline

epriestley created this revision.
This revision is now accepted and ready to land.Sep 19 2018, 11:18 PM
epriestley added inline comments.
src/filesystem/Filesystem.php
1057

("Hilariously", this is missing a third parameter and doesn't work at all, but got fixed later.)

This revision was automatically updated to reflect the committed changes.