Page MenuHomePhabricator
Differential D19633

Update some inline comment logic to use more modern "Viewer"-oriented calls/variables
ClosedPublic
Actions

Authored by epriestley on Sep 4 2018, 6:31 PM.
Tags
None
Referenced Files
F15471436: D19633.diff
Sat, Apr 5, 4:58 AM
F15465201: D19633.diff
Wed, Apr 2, 3:56 PM
F15442625: D19633.diff
Wed, Mar 26, 11:51 PM
F15430701: D19633.diff
Mon, Mar 24, 8:36 AM
F15411062: D19633.diff
Wed, Mar 19, 8:48 AM
F15410192: D19633.diff
Wed, Mar 19, 6:53 AM
F15404322: D19633.diff
Tue, Mar 18, 7:13 AM
F15394847: D19633.id46924.diff
Sun, Mar 16, 1:26 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T8573: All reviewers should be allowed to mark a comment as done
T13195: 2018 Week 36 Bonus Content
Commits
rP650e74933abb: Update some inline comment logic to use more modern "Viewer"-oriented…
Summary

Ref T13195. Ref T8573. The inline comment controllers currently use outdated $user = $this->getRequest()->getUser() calls.

Instead, use $viewer = $this->getViewer().

This is just a small consistency update with no behavioral changes.

Test Plan

Viewed and added inlines in Differential and Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
selfinline1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20732
Build 28183: Run Core Tests
Build 28182: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
12 lines
diffusion/
controller/
12 lines
infrastructure/
diff/
18 lines

Diff 46924

View Options

src/applications/differential/controller/DifferentialInlineCommentEditController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
Phabricator · Built by Phacility