Page MenuHomePhabricator

Update some inline comment logic to use more modern "Viewer"-oriented calls/variables
ClosedPublic

Authored by epriestley on Sep 4 2018, 6:31 PM.
Tags
None
Referenced Files
F15394847: D19633.id46924.diff
Sun, Mar 16, 1:26 AM
F15367998: D19633.diff
Tue, Mar 11, 11:02 PM
F15334952: D19633.diff
Sat, Mar 8, 1:15 PM
Unknown Object (File)
Mon, Feb 24, 7:38 PM
Unknown Object (File)
Mon, Feb 24, 3:09 AM
Unknown Object (File)
Sat, Feb 22, 10:43 AM
Unknown Object (File)
Fri, Feb 21, 12:55 AM
Unknown Object (File)
Tue, Feb 18, 12:09 AM
Subscribers
None

Details

Summary

Ref T13195. Ref T8573. The inline comment controllers currently use outdated $user = $this->getRequest()->getUser() calls.

Instead, use $viewer = $this->getViewer().

This is just a small consistency update with no behavioral changes.

Test Plan

Viewed and added inlines in Differential and Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
selfinline1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20732
Build 28183: Run Core Tests
Build 28182: arc lint + arc unit