Differential D19621

Allow the published version of a Phriction document to differ from the most recent version
ClosedPublic
Actions

Authored by epriestley on Aug 29 2018, 3:47 PM.

Tags

None

Referenced Files

	F13294909: D19621.diff
	Wed, Jun 5, 8:50 PM

	F13263857: D19621.diff
	Mon, May 27, 12:49 PM

	F13244004: D19621.diff
	Thu, May 23, 4:25 AM

	F13228797: D19621.id46901.diff
	Mon, May 20, 12:10 PM

	F13222488: D19621.diff
	Sun, May 19, 3:42 AM

	F13205123: D19621.diff
	Wed, May 15, 1:27 AM

	F13188459: D19621.diff
	Sat, May 11, 5:16 AM

	Unknown Object (File)
	May 7 2024, 8:30 AM

View All 61 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13077: Plans: Phriction modern "v3" APIs, Drafts

Commits

rP349686319e30: Allow the published version of a Phriction document to differ from the most…

Summary

Depends on D19620. Ref T13077. This adds a "Publish" operation which points the current version at some historical version of the document -- not necessarily the most recent version. Newer versions become "drafts".

This is still quite rough and missing a lot of hinting in the UI, I'm just making it work so I can start making the UI understand it.

Test Plan

Used the "Publish" action to publish older versions of a document, saw the document revert. Many UI hints are missing and this operation is puzzling and not yet usable for normal users.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 29 2018, 3:47 PM

Harbormaster completed remote builds in B20706: Diff 46901.Aug 29 2018, 3:48 PM

epriestley requested review of this revision.Aug 29 2018, 3:48 PM

epriestley added a child revision: D19622: Add a UI element for navigating between versions of a Phriction document.Aug 29 2018, 4:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2018, 8:47 PM

Closed by commit rP349686319e30: Allow the published version of a Phriction document to differ from the most… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

phriction/

application/

PhabricatorPhrictionApplication.php

2 lines

controller/

PhrictionDocumentController.php

29 lines

PhrictionPublishController.php

86 lines

xaction/

PhrictionDocumentPublishTransaction.php

71 lines

view/

phui/

PHUIDocumentView.php

11 lines

Diff 46905

src/__phutil_library_map__.php

Loading...

src/applications/phriction/application/PhabricatorPhrictionApplication.php

Loading...

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...

src/applications/phriction/controller/PhrictionPublishController.php

Loading...

src/applications/phriction/xaction/PhrictionDocumentPublishTransaction.php

Loading...

src/view/phui/PHUIDocumentView.php

Loading...