Page MenuHomePhabricator
Differential D19616

Rename "PHUIDocumentViewPro" to "PHUIDocumentView"
ClosedPublic
Actions

Authored by epriestley on Aug 28 2018, 9:00 PM.
Tags
None
Referenced Files
F15376674: D19616.diff
Thu, Mar 13, 5:01 AM
F15374582: D19616.id46893.diff
Wed, Mar 12, 8:03 PM
F15334435: D19616.diff
Sat, Mar 8, 9:09 AM
Unknown Object (File)
Feb 16 2025, 7:20 PM
Unknown Object (File)
Feb 12 2025, 2:51 AM
Unknown Object (File)
Feb 9 2025, 6:23 AM
Unknown Object (File)
Feb 9 2025, 6:23 AM
Unknown Object (File)
Feb 9 2025, 6:23 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rPfd0da4c41f82: Rename "PHUIDocumentViewPro" to "PHUIDocumentView"
Summary

Ref T13077. There is no "PHUIDocumentView" so toss the "Pro" suffix from this classname.

Test Plan

Grepped for PHUIDocumentView and PHUIDocumentViewPro.

Diff Detail

Repository
rP Phabricator
Branch
phriction1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20698
Build 28133: Run Core Tests
Build 28132: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 28 2018, 9:00 PM
Harbormaster completed remote builds in B20698: Diff 46893.Aug 28 2018, 9:01 PM
epriestley requested review of this revision.Aug 28 2018, 9:01 PM
epriestley added a child revision: D19617: Allow DocumentView to render with a curtain, and make Phriction use a curtain.Aug 28 2018, 9:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2018, 9:53 PM
Closed by commit rPfd0da4c41f82: Rename "PHUIDocumentViewPro" to "PHUIDocumentView" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46893

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/view/DiffusionReadmeView.php

Loading...
View Options

src/applications/diviner/controller/DivinerAtomController.php

Loading...
View Options

src/applications/diviner/controller/DivinerBookController.php

Loading...
View Options

src/applications/diviner/controller/DivinerMainController.php

Loading...
View Options

src/applications/guides/module/PhabricatorGuideInstallModule.php

Loading...
View Options

src/applications/guides/module/PhabricatorGuideQuickStartModule.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php

Loading...
View Options

src/applications/phame/controller/PhameHomeController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

src/view/phui/PHUIDocumentViewPro.php

Loading...
View Options

src/view/phui/PHUIRemarkupPreviewPanel.php

Loading...
Phabricator · Built by Phacility