Paths

Table of Contentst

Differential D19611

Repaint filetree more consistently for mobile/device views
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 5:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 25, 2:04 AM

	Unknown Object (File)
	Sat, Jan 25, 2:04 AM

	Unknown Object (File)
	Sat, Jan 25, 2:04 AM

	Unknown Object (File)
	Tue, Jan 21, 12:30 PM

	Unknown Object (File)
	Fri, Jan 17, 7:41 PM

	Unknown Object (File)
	Dec 23 2024, 12:35 PM

	Unknown Object (File)
	Dec 23 2024, 8:51 AM

	Unknown Object (File)
	Dec 8 2024, 1:42 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13189: Plans: 2018 Week 35 Bonus Content

Commits

rP415de4ce375a: Repaint filetree more consistently for mobile/device views

Summary

Ref T13189. See https://discourse.phabricator-community.org/t/diffusion-differential-mobile-layout-broken-when-enabling-file-tree/1751.

We currently call a nonexistent resetdrag() which does nothing. Some sequences of interactions can result in a blank left column in mobile/device widths.

Repaint the filetree away more consistently on device change.

Test Plan

Viewed a revision, toggled filetree off + on, resized to narrow width. Before: bad left margin, JS console error. After: proper repaint at device breakpoint, no JS console error.

Diff Detail

Repository

Branch

ftree1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20688
Build 28118: Run Core Tests
Build 28117: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 27 2018, 5:12 PM

Harbormaster completed remote builds in B20688: Diff 46883.Aug 27 2018, 5:13 PM

epriestley requested review of this revision.Aug 27 2018, 5:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2018, 5:32 PM

Closed by commit rP415de4ce375a: Repaint filetree more consistently for mobile/device views (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

js/

core/

behavior-phabricator-nav.js

51 lines

Diff 46883

resources/celerity/map.php

Loading...

webroot/rsrc/js/core/behavior-phabricator-nav.js

Loading...