Page MenuHomePhabricator

Repaint filetree more consistently for mobile/device views
ClosedPublic

Authored by epriestley on Aug 27 2018, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 1:42 PM
Unknown Object (File)
Fri, Dec 6, 10:52 PM
Unknown Object (File)
Sat, Nov 30, 8:21 AM
Unknown Object (File)
Thu, Nov 28, 8:48 PM
Unknown Object (File)
Nov 21 2024, 3:15 AM
Unknown Object (File)
Oct 21 2024, 11:15 AM
Unknown Object (File)
Oct 21 2024, 11:09 AM
Unknown Object (File)
Oct 21 2024, 6:10 AM
Subscribers
None

Details

Summary

Ref T13189. See https://discourse.phabricator-community.org/t/diffusion-differential-mobile-layout-broken-when-enabling-file-tree/1751.

We currently call a nonexistent resetdrag() which does nothing. Some sequences of interactions can result in a blank left column in mobile/device widths.

Repaint the filetree away more consistently on device change.

Test Plan

Viewed a revision, toggled filetree off + on, resized to narrow width. Before: bad left margin, JS console error. After: proper repaint at device breakpoint, no JS console error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2018, 5:32 PM
This revision was automatically updated to reflect the committed changes.