Page MenuHomePhabricator

Fix a minor text alignment issue for static text comment actions like "Accept Revision"
ClosedPublic

Authored by epriestley on Aug 24 2018, 5:09 PM.
Tags
None
Referenced Files
F15445766: D19600.diff
Thu, Mar 27, 3:54 PM
F15440358: D19600.id.diff
Wed, Mar 26, 12:23 PM
F15435895: D19600.diff
Tue, Mar 25, 10:47 AM
F15427288: D19600.id46860.diff
Sun, Mar 23, 1:33 PM
F15416473: D19600.diff
Thu, Mar 20, 11:21 AM
F15409941: D19600.id46860.diff
Wed, Mar 19, 6:03 AM
F15409672: D19600.id46860.diff
Wed, Mar 19, 4:51 AM
F15409222: D19600.id46860.diff
Wed, Mar 19, 3:39 AM
Subscribers
None

Details

Summary

Ref T13187. See PHI836. The "action" comment actions in Differential (Accept, Reject, etc) render a single line of descriptive text. This is currently slightly misaligned.

Give it similar sizing information to the label element to the left, so it lines up properly.

Test Plan

Note that "Request Review" and "This revision will be..." are now aligned:

Screen Shot 2018-08-24 at 10.07.37 AM.png (370×1 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:11 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.