Differential D19600

Fix a minor text alignment issue for static text comment actions like "Accept Revision"
ClosedPublic
Actions

Authored by epriestley on Aug 24 2018, 5:09 PM.

Tags

None

Referenced Files

	F15416473: D19600.diff
	Thu, Mar 20, 11:21 AM

	F15409941: D19600.id46860.diff
	Wed, Mar 19, 6:03 AM

	F15409672: D19600.id46860.diff
	Wed, Mar 19, 4:51 AM

	F15409222: D19600.id46860.diff
	Wed, Mar 19, 3:39 AM

	F15408974: D19600.id46860.diff
	Wed, Mar 19, 2:27 AM

	F15408774: D19600.id46860.diff
	Wed, Mar 19, 1:14 AM

	F15408588: D19600.id46860.diff
	Wed, Mar 19, 12:01 AM

	F15408402: D19600.id46860.diff
	Tue, Mar 18, 10:49 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13187: Plans: 2018 Week 34 Bonus Content

Commits

rP8a6d76784363: Fix a minor text alignment issue for static text comment actions like "Accept…

Summary

Ref T13187. See PHI836. The "action" comment actions in Differential (Accept, Reject, etc) render a single line of descriptive text. This is currently slightly misaligned.

Give it similar sizing information to the label element to the left, so it lines up properly.

Test Plan

Note that "Request Review" and "This revision will be..." are now aligned:

Screen Shot 2018-08-24 at 10.07.37 AM.png (370×1 px, 30 KB)

Diff Detail

Repository

rP Phabricator

Branch

layout1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20661
Build 28080: Run Core Tests
Build 28079: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 24 2018, 5:09 PM

Harbormaster completed remote builds in B20661: Diff 46860.Aug 24 2018, 5:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:11 PM

epriestley requested review of this revision.

Closed by commit rP8a6d76784363: Fix a minor text alignment issue for static text comment actions like "Accept… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

phui/

phui-form-view.css

3 lines

Diff 46860

View Options

resources/celerity/map.php