Currently the symbol generation scripts fail if passed a list containing no files because explode("\n", $input) returns array("") rather than array(). This means that a generic Harbormaster Build Plan with a step which executes find . -type f -name '*.php' | ./scripts/generate_php_symbols.php won't work because it fails in repositories that don't contain any PHP code.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPba25586016b2: Improve symbol generation scripts
Ran echo | generate_php_symbols and saw no output instead of an exception.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20619 Build 28020: Run Core Tests Build 28019: arc lint + arc unit
Event Timeline
Comment Actions
These scripts may not be long for this world (see T13047) but this change seems reasonable.