Differential D19578

Remove some array typehints for passing around
ClosedPublic
Actions

Authored by amckinley on Aug 13 2018, 10:38 PM.

Tags

None

Referenced Files

	F15483654: D19578.id46810.diff
	Wed, Apr 9, 1:41 PM

	F15482848: D19578.diff
	Wed, Apr 9, 8:26 AM

	F15477423: D19578.diff
	Mon, Apr 7, 2:37 PM

	F15466904: D19578.id46808.diff
	Thu, Apr 3, 10:39 AM

	F15454817: D19578.diff
	Sat, Mar 29, 8:33 PM

	F15445057: D19578.id46808.diff
	Thu, Mar 27, 12:22 PM

	F15416911: D19578.id46808.diff
	Thu, Mar 20, 2:23 PM

	F15416556: D19578.id46808.diff
	Thu, Mar 20, 12:00 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPcc1def6ceaab: Remove some array typehints for passing around

Summary

See discussion at https://secure.phabricator.com/D19492#241996

Test Plan

Refreshed a few Diffusion tabs; nothing broke.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20608
Build 27999: Run Core Tests
Build 27998: arc lint + arc unit

Event Timeline

amckinley created this revision.Aug 13 2018, 10:38 PM

Harbormaster completed remote builds in B20608: Diff 46808.Aug 13 2018, 10:39 PM

amckinley requested review of this revision.Aug 13 2018, 10:39 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 13 2018, 10:39 PM

epriestley accepted this revision.Aug 13 2018, 11:02 PM

This revision is now accepted and ready to land.Aug 13 2018, 11:02 PM

Closed by commit rPcc1def6ceaab: Remove some array typehints for passing around (authored by amckinley). · Explain WhyAug 13 2018, 11:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepositoryCommit.php

6 lines

subscriptions/

view/

SubscriptionListDialogBuilder.php

2 lines

Diff 46808

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php