Differential D19578

Remove some array typehints for passing around
ClosedPublic
Actions

Authored by amckinley on Aug 13 2018, 10:38 PM.

Tags

None

Referenced Files

	F15384332: D19578.id46810.diff
	Fri, Mar 14, 7:32 PM

	F15383158: D19578.id46808.diff
	Fri, Mar 14, 3:42 PM

	Unknown Object (File)
	Thu, Feb 27, 4:23 PM

	Unknown Object (File)
	Jan 28 2025, 5:23 AM

	Unknown Object (File)
	Dec 31 2024, 6:20 PM

	Unknown Object (File)
	Dec 31 2024, 6:20 PM

	Unknown Object (File)
	Dec 31 2024, 6:20 PM

	Unknown Object (File)
	Dec 28 2024, 4:18 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPcc1def6ceaab: Remove some array typehints for passing around

Summary

See discussion at https://secure.phabricator.com/D19492#241996

Test Plan

Refreshed a few Diffusion tabs; nothing broke.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20608
Build 27999: Run Core Tests
Build 27998: arc lint + arc unit

Event Timeline

amckinley created this revision.Aug 13 2018, 10:38 PM

Harbormaster completed remote builds in B20608: Diff 46808.Aug 13 2018, 10:39 PM

amckinley requested review of this revision.Aug 13 2018, 10:39 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 13 2018, 10:39 PM

epriestley accepted this revision.Aug 13 2018, 11:02 PM

This revision is now accepted and ready to land.Aug 13 2018, 11:02 PM

Closed by commit rPcc1def6ceaab: Remove some array typehints for passing around (authored by amckinley). · Explain WhyAug 13 2018, 11:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepositoryCommit.php

6 lines

subscriptions/

view/

SubscriptionListDialogBuilder.php

2 lines

Diff 46808

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php