Page MenuHomePhabricator

Remove 750ms timeout on owners path validation
ClosedPublic

Authored by epriestley on Aug 13 2018, 6:37 PM.
Tags
None
Referenced Files
F15366225: D19575.id46800.diff
Tue, Mar 11, 2:43 PM
F15344976: D19575.diff
Mon, Mar 10, 7:48 AM
F15330490: D19575.diff
Fri, Mar 7, 7:43 AM
Unknown Object (File)
Fri, Feb 21, 4:00 PM
Unknown Object (File)
Feb 9 2025, 6:17 AM
Unknown Object (File)
Feb 9 2025, 6:17 AM
Unknown Object (File)
Feb 9 2025, 6:17 AM
Unknown Object (File)
Feb 7 2025, 1:32 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI748. Path validation has a 750ms timeout which blames to rP5038ab850c, in 2011.

Production path validation is sometimes taking more than 750ms, particularly on the initial page load where we may validate many paths simultaneously.

I have no idea why we have this timeout, and it isn't consistent with how we perform other AJAX requests. Just remove it.

Test Plan
  • Reproduced issue in production, saw all validation calls failing at 750ms. Actual underlying calls succeed, they just take more than 750ms to resolve.
  • Loaded path validator locally, got green checkmark.

Diff Detail

Repository
rP Phabricator
Branch
opath1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20598
Build 27984: Run Core Tests
Build 27983: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 13 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.