Page MenuHomePhabricator

Remove 750ms timeout on owners path validation
ClosedPublic

Authored by epriestley on Aug 13 2018, 6:37 PM.
Tags
None
Referenced Files
F15525493: D19575.id46796.diff
Mon, Apr 21, 2:49 PM
F15472459: D19575.diff
Sat, Apr 5, 1:51 PM
F15453302: D19575.id46796.diff
Sat, Mar 29, 10:48 AM
F15446395: D19575.id46800.diff
Thu, Mar 27, 6:51 PM
F15445353: D19575.id.diff
Thu, Mar 27, 1:33 PM
F15441406: D19575.diff
Wed, Mar 26, 6:03 PM
F15421682: D19575.id.diff
Mar 22 2025, 1:35 AM
F15421188: D19575.id46796.diff
Mar 21 2025, 9:36 PM
Subscribers
None

Details

Summary

Ref T13164. See PHI748. Path validation has a 750ms timeout which blames to rP5038ab850c, in 2011.

Production path validation is sometimes taking more than 750ms, particularly on the initial page load where we may validate many paths simultaneously.

I have no idea why we have this timeout, and it isn't consistent with how we perform other AJAX requests. Just remove it.

Test Plan
  • Reproduced issue in production, saw all validation calls failing at 750ms. Actual underlying calls succeed, they just take more than 750ms to resolve.
  • Loaded path validator locally, got green checkmark.

Diff Detail

Repository
rP Phabricator
Branch
opath1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20598
Build 27984: Run Core Tests
Build 27983: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 13 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.