Page MenuHomePhabricator

Remove 750ms timeout on owners path validation
ClosedPublic

Authored by epriestley on Aug 13 2018, 6:37 PM.
Tags
None
Referenced Files
F18114064: D19575.id46796.diff
Wed, Aug 13, 3:35 AM
F17954232: D19575.id46800.diff
Fri, Aug 1, 3:55 AM
F17947917: D19575.id46800.diff
Thu, Jul 31, 7:19 PM
F17946308: D19575.id.diff
Thu, Jul 31, 2:12 PM
F17928883: D19575.diff
Jul 30 2025, 4:26 PM
F17909254: D19575.diff
Jul 29 2025, 2:16 PM
F17818558: D19575.id46796.diff
Jul 26 2025, 12:28 AM
F17796591: D19575.diff
Jul 25 2025, 1:05 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI748. Path validation has a 750ms timeout which blames to rP5038ab850c, in 2011.

Production path validation is sometimes taking more than 750ms, particularly on the initial page load where we may validate many paths simultaneously.

I have no idea why we have this timeout, and it isn't consistent with how we perform other AJAX requests. Just remove it.

Test Plan
  • Reproduced issue in production, saw all validation calls failing at 750ms. Actual underlying calls succeed, they just take more than 750ms to resolve.
  • Loaded path validator locally, got green checkmark.

Diff Detail

Repository
rP Phabricator
Branch
opath1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20598
Build 27984: Run Core Tests
Build 27983: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 13 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.