Page MenuHomePhabricator

In "bin/ssh-auth", cache a structure instead of a flat file because paths may change at runtime
ClosedPublic

Authored by epriestley on Aug 8 2018, 5:21 PM.
Tags
None
Referenced Files
F15463461: D19568.id46785.diff
Tue, Apr 1, 11:45 PM
F15456653: D19568.diff
Sun, Mar 30, 11:04 AM
F15443448: D19568.id.diff
Thu, Mar 27, 4:27 AM
F15437785: D19568.id46780.diff
Tue, Mar 25, 9:27 PM
F15418767: D19568.id46785.diff
Fri, Mar 21, 1:23 AM
F15415645: D19568.id46780.diff
Thu, Mar 20, 7:09 AM
F15412581: D19568.diff
Wed, Mar 19, 1:47 PM
F15406728: D19568.id.diff
Tue, Mar 18, 1:37 PM
Subscribers
None

Details

Summary

Fixes T12397. Ref T13164. See PHI801.

Several installs have hit various use cases where the path on disk where Phabricator lives changes at runtime. Currently, bin/ssh-auth caches a flat file which includes the path to bin/ssh-exec, so this may fall out of date if phabricator/ moves.

These use cases have varying strengths of legitimacy, but "we're migrating to a new set of hosts and the pool is half old machines and half new machines" seems reasonably compelling and not a problem entirely of one's own making.

Test Plan
  • Compared output on master to output after change, found them byte-for-byte identical.
  • Moved phabricator/ to phabricator2/, ran bin/ssh-auth, got updated output.
  • Added a new SSH key, saw it appear in the output.
  • Grepped for AUTHFILE_CACHEKEY (no hits).
  • Dropped the cache, verified that the file regenerates cleanly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable