Differential D19561

Consolidate redundant "should should" from some linter help strings in Arcanist
ClosedPublic
Actions

Authored by epriestley on Aug 3 2018, 7:59 PM.

Tags

None

Referenced Files

	F13223373: D19561.diff
	Sun, May 19, 4:32 AM

	F13201195: D19561.id46771.diff
	Tue, May 14, 9:11 AM

	F13179633: D19561.diff
	Wed, May 8, 9:19 PM

	Unknown Object (File)
	Mon, May 6, 12:27 PM

	Unknown Object (File)
	Mon, May 6, 12:13 PM

	Unknown Object (File)
	Mon, May 6, 8:01 AM

	Unknown Object (File)
	Sat, May 4, 6:54 PM

	Unknown Object (File)
	Wed, May 1, 12:22 AM

View All 76 Files

Subscribers

None

Tokens

"Pterodactyl" token, awarded by epriestley.

Details

Reviewers

amckinley

Commits

rARC9dfa68d739ee: (stable) Promote 2018 Week 31
rARCd9a4293ae734: Consolidate redundant "should should" from some linter help strings in Arcanist

Summary

See https://phabricator.wikimedia.org/T201138.

Test Plan

Read carefully.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 3 2018, 7:59 PM

Harbormaster completed remote builds in B20564: Diff 46765.Aug 3 2018, 7:59 PM

epriestley requested review of this revision.Aug 3 2018, 7:59 PM

This revision is now accepted and ready to land.Aug 3 2018, 8:35 PM

epriestley awarded a token.Aug 3 2018, 8:40 PM

Closed by commit rARCd9a4293ae734: Consolidate redundant "should should" from some linter help strings in Arcanist (authored by epriestley). · Explain WhyAug 3 2018, 9:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistDeprecationXHPASTLinterRule.php

2 lines

ArcanistUnsafeDynamicStringXHPASTLinterRule.php

6 lines

Diff 46771

View Options

src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php