Differential D19561

Consolidate redundant "should should" from some linter help strings in Arcanist
ClosedPublic
Actions

Authored by epriestley on Aug 3 2018, 7:59 PM.

Tags

None

Referenced Files

	F14405000: D19561.diff
	Mon, Dec 23, 6:37 AM

	Unknown Object (File)
	Fri, Dec 20, 6:49 PM

	Unknown Object (File)
	Nov 22 2024, 11:15 PM

	Unknown Object (File)
	Nov 22 2024, 11:15 PM

	Unknown Object (File)
	Nov 22 2024, 10:57 PM

	Unknown Object (File)
	Nov 5 2024, 11:16 PM

	Unknown Object (File)
	Oct 22 2024, 12:34 AM

	Unknown Object (File)
	Oct 18 2024, 2:52 PM

View All Files

Subscribers

None

Tokens

"Pterodactyl" token, awarded by epriestley.

Details

Reviewers

amckinley

Commits

rARC9dfa68d739ee: (stable) Promote 2018 Week 31
rARCd9a4293ae734: Consolidate redundant "should should" from some linter help strings in Arcanist

Summary

See https://phabricator.wikimedia.org/T201138.

Test Plan

Read carefully.

Diff Detail

Repository

rARC Arcanist

Branch

shouldshould1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20564
Build 27933: Run Core Tests
Build 27932: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 3 2018, 7:59 PM

Harbormaster completed remote builds in B20564: Diff 46765.Aug 3 2018, 7:59 PM

epriestley requested review of this revision.Aug 3 2018, 7:59 PM

This revision is now accepted and ready to land.Aug 3 2018, 8:35 PM

epriestley awarded a token.Aug 3 2018, 8:40 PM

Closed by commit rARCd9a4293ae734: Consolidate redundant "should should" from some linter help strings in Arcanist (authored by epriestley). · Explain WhyAug 3 2018, 9:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistDeprecationXHPASTLinterRule.php

2 lines

ArcanistUnsafeDynamicStringXHPASTLinterRule.php

6 lines

Diff 46765

View Options

src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php