Page MenuHomePhabricator
Differential D19558

Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing
ClosedPublic
Actions

Authored by artms on Aug 2 2018, 2:45 PM.
Tags
None
Referenced Files
F13243869: D19558.diff
Thu, May 23, 4:18 AM
F13222326: D19558.diff
Sun, May 19, 3:30 AM
F13204932: D19558.diff
Wed, May 15, 1:15 AM
F13201934: D19558.id.diff
Tue, May 14, 6:49 PM
F13190545: D19558.id46761.diff
Sat, May 11, 11:55 AM
F13188173: D19558.diff
Sat, May 11, 5:04 AM
Unknown Object (File)
Tue, May 7, 8:17 AM
Unknown Object (File)
Fri, May 3, 8:01 AM
View All 64 Files
Subscribers
Korvin

Details

Reviewers
Pawka
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP356b2781bcad: Gracefully fail request if non existing callsign is passed to…
Summary

diffusion.getrecentcommitsbypath fails with 500 error when non existing callsign is passed:

>>> UNRECOVERABLE FATAL ERROR <<<

Call to a member function getCommit() on null

Expected Behavior:
Return more graceful error notifying caller that such callsign/repository does not exist

Reproduction steps:
Open conduit: https://secure.phabricator.com/conduit/method/diffusion.getrecentcommitsbypath/
Enter:
callsign: "obviouslynotexisting"
path: "/random"
Click call method

Test Plan

after applying patch - call no longer fails with 500s

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

artms created this revision.Aug 2 2018, 2:45 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 2 2018, 2:45 PM
artms edited the summary of this revision. (Show Details)Aug 2 2018, 2:46 PM
Harbormaster completed remote builds in B20559: Diff 46760.Aug 2 2018, 2:46 PM
artms requested review of this revision.Aug 2 2018, 2:46 PM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 2 2018, 2:46 PM
epriestley accepted this revision.Aug 2 2018, 2:50 PM

This doesn't have any callers and should probably be frozen/deprecated, but this change won't hurt anything.

This revision is now accepted and ready to land.Aug 2 2018, 2:50 PM
artms added a comment.Aug 2 2018, 4:48 PM

Uh, we had couple of cases and this caused extra 500s in logs...

Closed by commit rP356b2781bcad: Gracefully fail request if non existing callsign is passed to… (authored by artms). · Explain WhyAug 2 2018, 4:49 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D19559: Deprecate Conduit method "diffusion.getrecentcommitsbypath".Aug 2 2018, 11:39 PM
epriestley mentioned this in rP3574a55a95bd: Deprecate Conduit method "diffusion.getrecentcommitsbypath".Aug 3 2018, 4:49 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
10 lines

Diff 46761

View Options

src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility