Paths

Table of Contentst

Differential D19554

Add Spaces information to the project list UI
ClosedPublic
Actions

Authored by epriestley on Jul 30 2018, 11:34 PM.

Tags

None

Referenced Files

	F14794442: D19554.id46750.diff
	Sat, Jan 25, 1:47 AM

	F14794440: D19554.id46745.diff
	Sat, Jan 25, 1:47 AM

	F14794439: D19554.id.diff
	Sat, Jan 25, 1:47 AM

	Unknown Object (File)
	Tue, Jan 21, 12:57 PM

	Unknown Object (File)
	Fri, Jan 17, 10:44 PM

	Unknown Object (File)
	Fri, Jan 3, 5:03 AM

	Unknown Object (File)
	Thu, Jan 2, 8:08 PM

	Unknown Object (File)
	Mon, Dec 30, 4:07 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rP45babe82f364: Add Spaces information to the project list UI

Summary

Depends on D19552. Ref T13164. We need this little setObject(...) hook to get the Space name into the search list UI.

Test Plan

Viewed project list, saw some Spaces listed.

Diff Detail

Repository

rP Phabricator

Branch

projectspace5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20544
Build 27906: Run Core Tests
Build 27905: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 30 2018, 11:34 PM

Harbormaster completed remote builds in B20544: Diff 46745.Jul 30 2018, 11:35 PM

epriestley requested review of this revision.Jul 30 2018, 11:35 PM

Specifically, this creates the little red "Secret Pocket" bit in the list:

Screen Shot 2018-07-30 at 4.39.55 PM.png (212×371 px, 20 KB)

amckinley accepted this revision.Jul 31 2018, 4:46 PM

This revision is now accepted and ready to land.Jul 31 2018, 4:46 PM

Closed by commit rP45babe82f364: Add Spaces information to the project list UI (authored by epriestley). · Explain WhyJul 31 2018, 5:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

view/

PhabricatorProjectListView.php

1 line

Diff 46745

View Options

src/applications/project/view/PhabricatorProjectListView.php

Add Spaces information to the project list UIClosedPublicActions