Carry the "silent" transaction flag through inverse edge edits
ClosedPublic
Actions

Authored by epriestley on Jul 27 2018, 6:13 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rPa5d3aea67c5b: Carry the "silent" transaction flag through inverse edge edits

Summary

See PHI751. Ref T13164. We added a "silent" flag for Editors somewhat recently (currently reachable only for bulk edits with bin/bulk ... command).

However, this flag doesn't carry through to the sub-editor when we make inverse edge edits. These are edits like "X is a parent of Y", which cause an implicit "Y is a child of X" edit to occur.

Pass the flag through.

Test Plan

Rigged the relationships controller to make silent edits.
Changed the parents of a revision from the web UI. Saw no mail or feed stories.

Diff Detail

Repository

rP Phabricator

Branch

silent1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20521
Build 27869: Run Core Tests
Build 27868: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 27 2018, 6:13 PM

Harbormaster completed remote builds in B20521: Diff 46724.Jul 27 2018, 6:14 PM

epriestley requested review of this revision.Jul 27 2018, 6:14 PM

amckinley accepted this revision.Jul 27 2018, 6:41 PM

This revision is now accepted and ready to land.Jul 27 2018, 6:41 PM

Closed by commit rPa5d3aea67c5b: Carry the "silent" transaction flag through inverse edge edits (authored by epriestley). · Explain WhyJul 27 2018, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

1 line

Diff 46724

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Carry the "silent" transaction flag through inverse edge editsClosedPublicActions