Page MenuHomePhabricator

Add an explicit "null" to a missed `diffusion.branchquery` callsite to fix Diffusion "Branches" page
ClosedPublic

Authored by epriestley on Jul 21 2018, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 11:12 PM
Unknown Object (File)
Sat, Dec 14, 1:32 PM
Unknown Object (File)
Fri, Dec 6, 4:47 PM
Unknown Object (File)
Wed, Dec 4, 5:52 PM
Unknown Object (File)
Tue, Nov 26, 1:16 PM
Unknown Object (File)
Nov 21 2024, 6:30 PM
Unknown Object (File)
Oct 22 2024, 2:41 PM
Unknown Object (File)
Oct 13 2024, 8:21 PM
Subscribers
None

Details

Summary

See PHI775. See D19499. Originally, see PHI720.

D19499 broke the standalone "Branches" page for commits. Normally, you reach this by taking these steps:

  • View a commit which is contained by 11 or more branches.
  • Click the "More Branches..." link in the "Branches" field.
  • You should be taken to a list of all branches which contain the commit.

The change to the 'branch' parameter was adjusted in the query that builds the "x, y, z, More Branches..." list, but not on the actual "Branches" list with the full list. Adjust it.

Test Plan
  • Set display limit to 1, viewed a commit on "master" and "stable", clicked "More Branches".
  • Before: saw only "master".
  • After: saw both "master" and "stable".

Diff Detail

Repository
rP Phabricator
Branch
branch1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20497
Build 27839: Run Core Tests
Build 27838: arc lint + arc unit