Fix querying for transactions over "transaction.search" when the object does not support comments
ClosedPublic
Actions

Authored by epriestley on Jun 25 2018, 1:01 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rPf94cee862888: Fix querying for transactions over "transaction.search" when the object does…

Summary

See PHI725. Ref T13151. We currently try to load comments unconditionally, but not all objects (like projects) have comments. Only try to load comments if an object actually has comments.

Test Plan

Queried for an object with no comments, like project #masonry, via transaction.search.

Diff Detail

Repository

rP Phabricator

Branch

xactionapi1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20452
Build 27779: Run Core Tests
Build 27778: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 25 2018, 1:01 PM

Harbormaster completed remote builds in B20452: Diff 46644.Jun 25 2018, 1:02 PM

epriestley requested review of this revision.Jun 25 2018, 1:02 PM

amckinley accepted this revision.Jun 25 2018, 4:29 PM

This revision is now accepted and ready to land.Jun 25 2018, 4:29 PM

Closed by commit rPf94cee862888: Fix querying for transactions over "transaction.search" when the object does… (authored by epriestley). · Explain WhyJun 26 2018, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

conduit/

TransactionSearchConduitAPIMethod.php

25 lines

Diff 46644

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Fix querying for transactions over "transaction.search" when the object does not support commentsClosedPublicActions