Page MenuHomePhabricator

Allow null identities to be attached to commit objects
ClosedPublic

Authored by amckinley on Jun 18 2018, 10:34 PM.
Tags
None
Referenced Files
F13238789: D19496.id46624.diff
Tue, May 21, 9:14 PM
F13237114: D19496.id.diff
Tue, May 21, 12:27 PM
F13198986: D19496.diff
Mon, May 13, 10:48 AM
F13178275: D19496.diff
Wed, May 8, 8:18 PM
Unknown Object (File)
Mon, May 6, 1:55 PM
Unknown Object (File)
Tue, Apr 30, 11:53 PM
Unknown Object (File)
Thu, Apr 25, 1:50 AM
Unknown Object (File)
Mar 31 2024, 11:44 PM
Subscribers

Details

Summary

I landed D19491 a little aggressively, so allow this field to be null until after the migration goes out.

Test Plan

Loaded commits without identity objects; did not get any errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You can also ClassName $v = null to let null through. PHP is a beautiful wild creature.

This revision is now accepted and ready to land.Jun 19 2018, 7:25 PM

That is, the typehint ClassName $x allows only ClassName objects. The typehint ClassName $x = null allows ClassName objects or null, as an amazing side effect of defaulting the parameter to null.

This revision was automatically updated to reflect the committed changes.