Allow null identities to be attached to commit objects
ClosedPublic
Actions

Authored by amckinley on Jun 18 2018, 10:34 PM.

Details

Reviewers

epriestley

Commits

rP9db5ad3476a9: Allow null identities to be attached to commit objects

Summary

I landed D19491 a little aggressively, so allow this field to be null until after the migration goes out.

Test Plan

Loaded commits without identity objects; did not get any errors.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20430
Build 27746: Run Core Tests
Build 27745: arc lint + arc unit

Event Timeline

amckinley created this revision.Jun 18 2018, 10:34 PM

Harbormaster completed remote builds in B20430: Diff 46624.Jun 18 2018, 10:36 PM

amckinley requested review of this revision.Jun 18 2018, 10:36 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJun 18 2018, 10:36 PM

You can also ClassName $v = null to let null through. PHP is a beautiful wild creature.

This revision is now accepted and ready to land.Jun 19 2018, 7:25 PM

That is, the typehint ClassName $x allows only ClassName objects. The typehint ClassName $x = null allows ClassName objects or null, as an amazing side effect of defaulting the parameter to null.

Closed by commit rP9db5ad3476a9: Allow null identities to be attached to commit objects (authored by amckinley). · Explain WhyJun 20 2018, 3:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepositoryCommit.php

2 lines

Diff 46624

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Allow null identities to be attached to commit objectsClosedPublicActions