Page MenuHomePhabricator

Allow null identities to be attached to commit objects
ClosedPublic

Authored by amckinley on Jun 18 2018, 10:34 PM.
Tags
None
Referenced Files
F15460020: D19496.id46628.diff
Mon, Mar 31, 7:21 PM
F15458480: D19496.id46624.diff
Mon, Mar 31, 4:00 AM
F15458479: D19496.id46628.diff
Mon, Mar 31, 4:00 AM
F15453501: D19496.diff
Sat, Mar 29, 12:15 PM
F15452291: D19496.diff
Sat, Mar 29, 3:35 AM
F15447713: D19496.id46624.diff
Fri, Mar 28, 1:12 AM
F15440304: D19496.id.diff
Wed, Mar 26, 12:01 PM
F15437373: D19496.diff
Tue, Mar 25, 7:02 PM
Subscribers

Details

Summary

I landed D19491 a little aggressively, so allow this field to be null until after the migration goes out.

Test Plan

Loaded commits without identity objects; did not get any errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You can also ClassName $v = null to let null through. PHP is a beautiful wild creature.

This revision is now accepted and ready to land.Jun 19 2018, 7:25 PM

That is, the typehint ClassName $x allows only ClassName objects. The typehint ClassName $x = null allows ClassName objects or null, as an amazing side effect of defaulting the parameter to null.

This revision was automatically updated to reflect the committed changes.