Page MenuHomePhabricator

Prevent creation of empty repository identities
ClosedPublic

Authored by amckinley on Jun 5 2018, 10:59 PM.
Tags
None
Referenced Files
F15414029: D19466.diff
Wed, Mar 19, 10:39 PM
Unknown Object (File)
Fri, Feb 21, 2:42 AM
Unknown Object (File)
Feb 18 2025, 2:46 AM
Unknown Object (File)
Feb 15 2025, 1:38 PM
Unknown Object (File)
Feb 9 2025, 6:25 AM
Unknown Object (File)
Feb 9 2025, 6:06 AM
Unknown Object (File)
Feb 9 2025, 6:06 AM
Unknown Object (File)
Feb 9 2025, 6:06 AM
Subscribers

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20371
Build 27665: Run Core Tests
Build 27664: arc lint + arc unit

Event Timeline

epriestley added inline comments.
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
82–83

We could probably skip this query, too, if $committer === null since we (should) never get a hit for it.

This revision is now accepted and ready to land.Jun 5 2018, 11:06 PM
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
82–83

Yeah, I just left it so that $committer_identity would always be defined. Will clean it up.

This revision was automatically updated to reflect the committed changes.

I cherry-picked this to stable for good measure.