Page MenuHomePhabricator
Differential D19466

Prevent creation of empty repository identities
ClosedPublic
Actions

Authored by amckinley on Jun 5 2018, 10:59 PM.
Tags
None
Referenced Files
F18953164: D19466.diff
Wed, Nov 12, 7:09 AM
F18785003: D19466.id.diff
Oct 13 2025, 4:42 PM
F18779108: D19466.id46564.diff
Oct 11 2025, 12:05 PM
F18754584: D19466.id.diff
Oct 4 2025, 11:43 PM
F18754475: D19466.diff
Oct 4 2025, 11:11 PM
F18652002: D19466.id46563.diff
Sep 21 2025, 6:16 AM
F18593981: D19466.id.diff
Sep 12 2025, 4:38 PM
F18581765: D19466.diff
Sep 11 2025, 6:51 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP994ed5998f00: (stable) Prevent creation of empty repository identities
rPb8b2d1672dc3: Prevent creation of empty repository identities
Summary

Fixes issue reported in https://secure.phabricator.com/rPf191a66490b194785fae28c062b71be99bb14584#43240

Test Plan

Imported an SVN repo, observed clean import instead of daemon exception.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20370
Build 27663: Run Core Tests
Build 27662: arc lint + arc unit

Event Timeline

amckinley created this revision.Jun 5 2018, 10:59 PM
Harbormaster completed remote builds in B20370: Diff 46562.Jun 5 2018, 11:00 PM
amckinley requested review of this revision.Jun 5 2018, 11:00 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJun 5 2018, 11:00 PM
epriestley accepted this revision.Jun 5 2018, 11:06 PM
epriestley added inline comments.
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
83–86

We could probably skip this query, too, if $committer === null since we (should) never get a hit for it.

This revision is now accepted and ready to land.Jun 5 2018, 11:06 PM
amckinley added inline comments.Jun 5 2018, 11:09 PM
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
83–86

Yeah, I just left it so that $committer_identity would always be defined. Will clean it up.

amckinley updated this revision to Diff 46563.Jun 5 2018, 11:12 PM

Cleaner logic

Harbormaster completed remote builds in B20371: Diff 46563.Jun 5 2018, 11:13 PM
Closed by commit rPb8b2d1672dc3: Prevent creation of empty repository identities (authored by amckinley). · Explain WhyJun 5 2018, 11:14 PM
This revision was automatically updated to reflect the committed changes.
amckinley mentioned this in rPf191a66490b1: Add controllers/search/edit engine functionality to RepositoryIdentity.Jun 5 2018, 11:23 PM
epriestley added a comment.Jun 7 2018, 4:09 PM

I cherry-picked this to stable for good measure.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
worker/
commitmessageparser/
7 lines

Diff 46562

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility