Page MenuHomePhabricator

Fix Javascript busy loop when trying to delete tokens from an empty tokenizer
ClosedPublic

Authored by epriestley on Jun 1 2018, 8:08 PM.
Tags
None
Referenced Files
F15383708: D19456.id46543.diff
Fri, Mar 14, 5:39 PM
F15337170: D19456.diff
Sun, Mar 9, 4:31 AM
Unknown Object (File)
Sat, Feb 22, 12:40 AM
Unknown Object (File)
Fri, Feb 21, 3:37 PM
Unknown Object (File)
Feb 9 2025, 6:06 AM
Unknown Object (File)
Feb 9 2025, 6:05 AM
Unknown Object (File)
Feb 9 2025, 6:05 AM
Unknown Object (File)
Feb 4 2025, 6:37 PM
Subscribers
None

Details

Summary

Fixes T13147. In D19437, I changed this logic to support deleting the "" (empty string) token, but [].pop() returns undefined, not null, if the list is empty and I didn't think to try deleting an empty input.

Fix the logic so we don't end up in a loop if the input is empty.

Test Plan
  • In any browser, deleted all tokens in a tokenizer; then pressed delete again.
  • Before: tab hangs in an infinte loop.
  • After: smooth sailing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

👍
Javascript is !!fun!!.

This revision is now accepted and ready to land.Jun 1 2018, 8:27 PM
This revision was automatically updated to reflect the committed changes.