Page MenuHomePhabricator

Fix Javascript busy loop when trying to delete tokens from an empty tokenizer
ClosedPublic

Authored by epriestley on Jun 1 2018, 8:08 PM.
Tags
None
Referenced Files
F16450454: D19456.diff
Mon, Jun 16, 2:38 PM
F16450238: D19456.diff
Mon, Jun 16, 2:37 PM
Unknown Object (File)
Fri, May 30, 7:40 PM
Unknown Object (File)
May 9 2025, 9:44 PM
Unknown Object (File)
May 5 2025, 10:21 PM
Unknown Object (File)
Apr 22 2025, 4:12 AM
Unknown Object (File)
Apr 12 2025, 6:15 AM
Unknown Object (File)
Apr 8 2025, 9:00 AM
Subscribers
None

Details

Summary

Fixes T13147. In D19437, I changed this logic to support deleting the "" (empty string) token, but [].pop() returns undefined, not null, if the list is empty and I didn't think to try deleting an empty input.

Fix the logic so we don't end up in a loop if the input is empty.

Test Plan
  • In any browser, deleted all tokens in a tokenizer; then pressed delete again.
  • Before: tab hangs in an infinte loop.
  • After: smooth sailing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

👍
Javascript is !!fun!!.

This revision is now accepted and ready to land.Jun 1 2018, 8:27 PM
This revision was automatically updated to reflect the committed changes.