Page MenuHomePhabricator

Fix Javascript busy loop when trying to delete tokens from an empty tokenizer
ClosedPublic

Authored by epriestley on Jun 1 2018, 8:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 7:06 AM
Unknown Object (File)
Sat, Jan 25, 1:32 AM
Unknown Object (File)
Sat, Jan 25, 1:32 AM
Unknown Object (File)
Sat, Jan 25, 1:31 AM
Unknown Object (File)
Thu, Jan 23, 2:13 PM
Unknown Object (File)
Fri, Jan 17, 6:40 PM
Unknown Object (File)
Thu, Jan 9, 11:23 PM
Unknown Object (File)
Thu, Jan 9, 2:08 PM
Subscribers
None

Details

Summary

Fixes T13147. In D19437, I changed this logic to support deleting the "" (empty string) token, but [].pop() returns undefined, not null, if the list is empty and I didn't think to try deleting an empty input.

Fix the logic so we don't end up in a loop if the input is empty.

Test Plan
  • In any browser, deleted all tokens in a tokenizer; then pressed delete again.
  • Before: tab hangs in an infinte loop.
  • After: smooth sailing.

Diff Detail

Repository
rP Phabricator
Branch
loop1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20352
Build 27639: Run Core Tests
Build 27638: arc lint + arc unit

Event Timeline

👍
Javascript is !!fun!!.

This revision is now accepted and ready to land.Jun 1 2018, 8:27 PM
This revision was automatically updated to reflect the committed changes.