Differential D19447

Allow number in generated clone uri
ClosedPublic
Actions

Authored by avivey on May 11 2018, 5:05 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP728130044652: Allow number in generated clone uri

Summary

See https://discourse.phabricator-community.org/t/numerical-characters-are-stripped-from-diffusion-git-repository-name-in-the-uri/

Digits are often considered reasonable characters.

Test Plan

Looked at an ascii table.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20321
Build 27595: Run Core Tests
Build 27594: arc lint + arc unit

Event Timeline

avivey created this revision.May 11 2018, 5:05 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 11 2018, 5:05 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B20321: Diff 46515.May 11 2018, 5:07 AM

avivey requested review of this revision.May 11 2018, 5:07 AM

Sam2304 added a subscriber: Sam2304.May 11 2018, 9:51 AM

Thanks!

This revision is now accepted and ready to land.May 11 2018, 1:50 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 11 2018, 1:50 PM

Closed by commit rP728130044652: Allow number in generated clone uri (authored by avivey). · Explain WhyMay 11 2018, 4:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

2 lines

Diff 46515

View Options

src/applications/repository/storage/PhabricatorRepository.php

Allow number in generated clone uriClosedPublicActions