Page MenuHomePhabricator

More-robust search for task assignees
ClosedPublic

Authored by amckinley on Apr 30 2018, 7:11 PM.
Tags
None
Referenced Files
F14890616: D19417.id46448.diff
Sun, Feb 9, 6:01 AM
F14890615: D19417.id46446.diff
Sun, Feb 9, 6:01 AM
F14890614: D19417.id.diff
Sun, Feb 9, 6:01 AM
F14890613: D19417.diff
Sun, Feb 9, 6:01 AM
Unknown Object (File)
Wed, Jan 29, 4:57 AM
Unknown Object (File)
Sat, Jan 25, 1:22 AM
Unknown Object (File)
Sat, Jan 25, 1:22 AM
Unknown Object (File)
Sat, Jan 25, 1:21 AM
Subscribers

Details

Summary

See discussion in D19415.

Test Plan

Searched for some owners, found tasks as expected.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20257
Build 27495: Run Core Tests
Build 27494: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 30 2018, 7:16 PM
This revision was automatically updated to reflect the committed changes.

This actually caused an AphrontParameterQueryException while loading the Maniphest home page due to $this->ownerPHIDs being an empty array. I attempted to fix it by changing line 588 to:

if (($this->ownerPHIDs !== null) and !empty($this->ownerPHIDs)) {

which seems to work. I have no idea what side-effects this "fix" might cause though, I'm still waiting for my team to complain.

If you'd like that fixed, please file a bug report on the Discourse forum, including reproduction instructions that others can follow to reproduce the issue. A link to a page on this install which fatals would be sufficient.