Page MenuHomePhabricator

Fix excessively severe CSP URI error during first-time setup
ClosedPublic

Authored by epriestley on Apr 21 2018, 4:31 PM.
Tags
None
Referenced Files
F18858178: D19396.id.diff
Sat, Nov 1, 9:04 PM
F18854231: D19396.diff
Fri, Oct 31, 10:37 PM
F18846854: D19396.diff
Wed, Oct 29, 9:30 PM
F18820130: D19396.id46397.diff
Wed, Oct 22, 12:45 PM
F18788452: D19396.diff
Wed, Oct 15, 5:00 AM
F18721334: D19396.id.diff
Sep 29 2025, 8:56 PM
F18708308: D19396.diff
Sep 28 2025, 9:23 PM
F18679678: D19396.id46397.diff
Sep 26 2025, 1:14 AM
Subscribers
None

Details

Summary

See D19394. Currently, during first-time setup before you configure "phabricator.base-uri", we may attempt to generate a setup page, try to generate a CSP header for it, and fail to access the environmental config. This causes a too-severe error page ("configure phabricator.base-uri") instead of preflight guidance (like "can't connect to MySQL").

Instead, treat this more like "security.alternate-file-domain" and just bail on CSP if we can't fetch it.

Test Plan

On a fresh (non-explodey laptop) install with critical setup errors (no MySQL installed yet), loaded Phabricator. Before: error about phabricator.base-uri. After: more helpful guidance about installing/configuring MySQL.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable