Paths

Table of Contentst

Differential D19377

Remove obsoleted "diffusion-browse-file" behavior for coverage
ClosedPublic
Actions

Authored by epriestley on Apr 17 2018, 12:54 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rP21bb0215dbc7: Remove obsoleted "diffusion-browse-file" behavior for coverage

Summary

Ref T13105. After moving Diffusion to DocumnentEngine, this no longer has callers. It will become part of the document behavior.

Test Plan

Grepped for calls to the diffusion-browse-file behavior, found none.

Diff Detail

Repository

rP Phabricator

Branch

covui1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20167
Build 27362: Run Core Tests
Build 27361: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2018, 12:54 PM

Harbormaster completed remote builds in B20167: Diff 46352.Apr 17 2018, 12:56 PM

epriestley requested review of this revision.Apr 17 2018, 12:56 PM

epriestley added a child revision: D19378: Restore coverage reporting to Diffusion browse UI.Apr 17 2018, 1:46 PM

amckinley accepted this revision.Apr 17 2018, 4:43 PM

This revision is now accepted and ready to land.Apr 17 2018, 4:43 PM

Closed by commit rP21bb0215dbc7: Remove obsoleted "diffusion-browse-file" behavior for coverage (authored by epriestley). · Explain WhyApr 17 2018, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

8 lines

webroot/

rsrc/

js/

application/

diffusion/

behavior-diffusion-browse-file.js

Diff 46352

View Options

resources/celerity/map.php