Page MenuHomePhabricator

Fix the legacy "25, 50, 100, unlimited" Harbormaster log links to respect generation selection
ClosedPublic

Authored by epriestley on Apr 13 2018, 1:50 PM.
Tags
None
Referenced Files
F15384413: D19367.diff
Fri, Mar 14, 7:48 PM
F15380730: D19367.id46331.diff
Fri, Mar 14, 4:14 AM
Unknown Object (File)
Sun, Mar 2, 10:42 PM
Unknown Object (File)
Mon, Feb 24, 6:29 PM
Unknown Object (File)
Feb 16 2025, 6:06 PM
Unknown Object (File)
Jan 28 2025, 3:45 AM
Unknown Object (File)
Dec 9 2024, 4:02 AM
Unknown Object (File)
Dec 5 2024, 9:37 AM
Subscribers
Restricted Owners Package

Details

Summary

See PHI565. Ref T13120. Although this older log is on the chopping block (see T13088), there's some migration guidance and other complexity around just replacing it.

Until it gets replaced, make clicking the "number of lines" elements respect the current "Build Generation" setting. Prior to this change, clicking the links would lose the generation information and jump you to the most recent build generation.

Also fix some collateral damage from T13105 where we ended up with white text on a white background in some cases.

Test Plan
  • Restarted a build to get multiple generations.
  • On each generation, clicked the various "25", "50", etc., links.
  • Saw generation and log window sizes both respected by the links.

Diff Detail

Repository
rP Phabricator
Branch
hlog1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20142
Build 27326: Run Core Tests
Build 27325: arc lint + arc unit