Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats
ClosedPublic
Actions

Authored by epriestley on Apr 5 2018, 1:15 PM.

Details

Reviewers: None
Commits: rP0fef964d86de: (stable) Fix a commit hook issue where pushing dangerous changes would fatal…
rP3de002c8414a: Fix a commit hook issue where pushing dangerous changes would fatal before…

Summary

See https://discourse.phabricator-community.org/t/php-fatal-when-using-git-push-d/1317. The behavioral changes for Herald on initial import from D19265 could leave $all_updates undefined if we throw early enough.

Test Plan

Pushed a dangerous change, saw dragon bureaucrats again.

Repository

rP Phabricator

Branch

allup

Lint

Lint Passed

Unit

Tests Passed

Build Status

epriestley requested review of this revision.Apr 5 2018, 1:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 1:19 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

diffusion/

engine/

1 line