HomePhabricator

(stable) Fix a commit hook issue where pushing dangerous changes would fatal…

Description

(stable) Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats

Summary: See https://discourse.phabricator-community.org/t/php-fatal-when-using-git-push-d/1317. The behavioral changes for Herald on initial import from D19265 could leave $all_updates undefined if we throw early enough.

Test Plan: Pushed a dangerous change, saw dragon bureaucrats again.

Differential Revision: https://secure.phabricator.com/D19297

Details

Provenance
epriestleyAuthored on Apr 5 2018, 12:26 PM
epriestleyPushed on Apr 5 2018, 1:20 PM
Differential Revision
D19297: Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats
Parents
rP126f7f0d561c: (stable) Promote 2018 Week 13
Branches
Unknown
Tags
Unknown
Build Status
Buildable 20003
Build 27122: Run Core Tests