Page MenuHomePhabricator
Differential D19297

Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats
ClosedPublic
Actions

Authored by epriestley on Apr 5 2018, 1:15 PM.
Tags
None
Referenced Files
F13208008: D19297.id46180.diff
Thu, May 16, 7:40 AM
F13207985: D19297.diff
Thu, May 16, 7:14 AM
F13192709: D19297.diff
Sun, May 12, 9:28 AM
F13191841: D19297.id46181.diff
Sun, May 12, 1:14 AM
F13180629: D19297.id.diff
Thu, May 9, 1:49 AM
F13178989: D19297.id46181.diff
Wed, May 8, 8:51 PM
F13175407: D19297.diff
Wed, May 8, 5:02 AM
Unknown Object (File)
Sun, May 5, 7:44 AM
View All 90 Files
Subscribers
None

Details

Reviewers
None
Commits
rP0fef964d86de: (stable) Fix a commit hook issue where pushing dangerous changes would fatal…
rP3de002c8414a: Fix a commit hook issue where pushing dangerous changes would fatal before…
Summary

See https://discourse.phabricator-community.org/t/php-fatal-when-using-git-push-d/1317. The behavioral changes for Herald on initial import from D19265 could leave $all_updates undefined if we throw early enough.

Test Plan

Pushed a dangerous change, saw dragon bureaucrats again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 5 2018, 1:15 PM
Harbormaster completed remote builds in B20001: Diff 46180.Apr 5 2018, 1:16 PM
epriestley requested review of this revision.Apr 5 2018, 1:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 1:19 PM
Closed by commit rP3de002c8414a: Fix a commit hook issue where pushing dangerous changes would fatal before… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
1 line

Diff 46181

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
Phabricator · Built by Phacility