Page MenuHomePhabricator
Differential D19297

Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats
ClosedPublic
Actions

Authored by epriestley on Apr 5 2018, 1:15 PM.
Tags
None
Referenced Files
F15448176: D19297.id46181.diff
Fri, Mar 28, 3:21 AM
F15448175: D19297.id.diff
Fri, Mar 28, 3:21 AM
F15446066: D19297.id46180.diff
Thu, Mar 27, 4:58 PM
F15442613: D19297.diff
Wed, Mar 26, 11:50 PM
F15424756: D19297.diff
Sun, Mar 23, 12:14 AM
F15423899: D19297.diff
Sat, Mar 22, 7:19 PM
F15412365: D19297.diff
Wed, Mar 19, 12:40 PM
F15331817: D19297.diff
Mar 7 2025, 2:01 PM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rP0fef964d86de: (stable) Fix a commit hook issue where pushing dangerous changes would fatal…
rP3de002c8414a: Fix a commit hook issue where pushing dangerous changes would fatal before…
Summary

See https://discourse.phabricator-community.org/t/php-fatal-when-using-git-push-d/1317. The behavioral changes for Herald on initial import from D19265 could leave $all_updates undefined if we throw early enough.

Test Plan

Pushed a dangerous change, saw dragon bureaucrats again.

Diff Detail

Repository
rP Phabricator
Branch
allup
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20001
Build 27120: Run Core Tests
Build 27119: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 5 2018, 1:15 PM
Harbormaster completed remote builds in B20001: Diff 46180.Apr 5 2018, 1:16 PM
epriestley requested review of this revision.Apr 5 2018, 1:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2018, 1:19 PM
Closed by commit rP3de002c8414a: Fix a commit hook issue where pushing dangerous changes would fatal before… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
1 line

Diff 46180

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
Phabricator · Built by Phacility