Page MenuHomePhabricator
Differential D19274

Support text encoding and syntax highlighting options in document rendering
ClosedPublic
Actions

Authored by epriestley on Mar 30 2018, 6:15 PM.
Tags
None
Referenced Files
F15418972: D19274.diff
Fri, Mar 21, 2:45 AM
F15283377: D19274.id46135.diff
Tue, Mar 4, 7:05 AM
Unknown Object (File)
Mon, Feb 24, 6:25 PM
Unknown Object (File)
Mon, Feb 24, 1:28 PM
Unknown Object (File)
Feb 16 2025, 12:49 PM
Unknown Object (File)
Jan 31 2025, 4:38 AM
Unknown Object (File)
Jan 30 2025, 6:00 PM
Unknown Object (File)
Jan 28 2025, 1:30 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rP7189cb7ba816: Support text encoding and syntax highlighting options in document rendering
Summary

Depends on D19273. Ref T13105. Adds "Change Text Encoding..." and "Highlight As..." options when rendering documents, and makes an effort to automatically detect and handle text encoding.

Test Plan
  • Uploaded a Shift-JIS file, saw it auto-detect as Shift-JIS.
  • Converted files between encodings.
  • Highlighted various things as "Rainbow", etc.

Diff Detail

Repository
rP Phabricator
Branch
doce2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19956
Build 27054: Run Core Tests
Build 27053: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 30 2018, 6:15 PM
Harbormaster completed remote builds in B19956: Diff 46135.Mar 30 2018, 6:16 PM
epriestley requested review of this revision.Mar 30 2018, 6:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 6:28 PM
Closed by commit rP7189cb7ba816: Support text encoding and syntax highlighting options in document rendering (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
src/
applications/
files/
controller/
10 lines
24 lines
document/
28 lines
17 lines
60 lines
webroot/
rsrc/
js/
application/
files/
99 lines
phuix/
4 lines

Diff 46135

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDocumentController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileViewController.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...
View Options

webroot/rsrc/js/application/files/behavior-document-engine.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXActionView.js

Loading...
Phabricator · Built by Phacility